Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSOC-67] Migration of USBL plugins #11

Merged
merged 16 commits into from
Jul 19, 2024
Merged

[GSOC-67] Migration of USBL plugins #11

merged 16 commits into from
Jul 19, 2024

Conversation

hmoyen
Copy link
Collaborator

@hmoyen hmoyen commented Jul 13, 2024

This PR introduces three main features:

  1. USBL Plugins:

    • Transceiver Plugin: Compatible with ROS 2 and Harmonic.
    • Transponder Plugin: Compatible with ROS 2 and Harmonic.
  2. Tutorial World:

    • Added usbl_tutorial.world to demonstrate the usage of the new USBL plugins.
  3. World Launch File:

    • Included a verbose argument to enable monitoring of the plugin's Gazebo messages.

Documentation on how to use the plugin is here: Documentation

@hmoyen
Copy link
Collaborator Author

hmoyen commented Jul 15, 2024

@woensug-choi The pre-commit seems to be failing due to /usr/bin/env: ament_cppcheck: No such file or directory and Executable ament_cpplint not found . I am not so familiar with pre-commit, but could it be some configuration that is missing in github workflows?

@woensug-choi
Copy link

woensug-choi commented Jul 15, 2024

Try

pip3 install pre-commit && pre-commit install && pre-commit run --all-files

oh.. didn't work on my side too. I may caued this. ignore it for now

@woensug-choi
Copy link

woensug-choi commented Jul 15, 2024

@hmoyen

  • Wouldn't setting the channel mean individual mode?
    Is is correct that when channel is fixed to one transponder ros2 topic pub --once /USBL/transceiver_manufacturer_168/channel_switch std_msgs/String "data: '1'" will implicitly mean that the user is using individual mode? Initiated at common mode and setting channel_switch to `data: '1' still printed every transponder data.

  • If having individual mode, then the transceiver should be able to recognize different transponder signals?
    If so, shouldn't we need to add transponder name on transponder_location msg?

@hmoyen
Copy link
Collaborator Author

hmoyen commented Jul 15, 2024

@woensug-choi here are the changes made:

  • Location.msg was created to include transponder_id in the location topic messages.
  • If attempting to use the individual ping topic without being in individual mode, it won't respond. Gazebo will indicate that individual mode isn't set.
  • Requesting a channel switch automatically changes the mode to individual.

@woensug-choi
Copy link

ros2 topic echo /USBL/transceiver_manufacturer_168/transponder_location

returned

The message type 'dave_interfaces/msg/Location' is invalid

@hmoyen
Copy link
Collaborator Author

hmoyen commented Jul 19, 2024

@woensug-choi It used to happen for me too when I did not source install/setup.bash (dave's workspace) in the current terminal.

@hmoyen hmoyen merged commit 0f1378e into ros2 Jul 19, 2024
1 check passed
@hmoyen hmoyen deleted the usbl-plugins branch July 19, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants