(Host|Service) Detail view: Introduce parents and children tab #1098

sukhwinder33445 · 2024-11-25T14:19:04Z

No description provided.

nilmerg

From the issue:

The tabs are only visible if the object is linked in the database table dependency_node.

The tabs are always visible right now.

raviks789 · 2024-12-16T11:18:45Z

Except for the error in the search bar while trying to apply filter in Parents/Children tabs, everything else seems to work as listed out in the issue.

raviks789 · 2024-12-16T14:07:51Z

application/controllers/HostController.php

@@ -55,13 +66,18 @@ public function init()
        }

        $this->host = $host;
-        $this->loadTabsForObject($host);
+        $this->loadTabsForObject($this->host);


Is there a reason for this change?

Not really, I have reverted the change.

raviks789 · 2024-12-16T14:08:44Z

application/controllers/HostController.php

+                $this->sendMultipartUpdate();
+                return;


Suggested change

$this->sendMultipartUpdate();

return;

$this->sendMultipartUpdate();

return;

raviks789 · 2024-12-16T14:11:59Z

application/controllers/HostController.php

+                'name'                                  => t('Name'),
+                'severity desc, last_state_change desc' => t('Severity'),
+                'state'                                 => t('Current State'),
+                'last_state_change desc'                => t('Last State Change')


You could use $this->translate() method instead as you have done in parentsAction for translation. Also, you seemed to have use the function t() in some places and $this->translate() in some places.

raviks789 · 2024-12-16T14:21:42Z

application/controllers/HostController.php

    protected function createTabs(): Tabs
    {
+        $hasDependencyNode = DependencyNode::on($this->getDb())
+                ->columns('1')


Suggested change

->columns('1')

->columns([new ipl\Sql\Expression('1')])

raviks789 · 2024-12-16T14:33:34Z

application/controllers/ServiceController.php

+    protected function createTabs(): Tabs
+    {
+        $hasDependecyNode = DependencyNode::on($this->getDb())
+                ->columns('1')


Suggested change

->columns('1')

->columns([[new ipl\Sql\Expression('1')]])

raviks789 · 2024-12-16T17:16:47Z

application/controllers/ServiceController.php

@@ -63,7 +72,12 @@ public function init()
        }

        $this->service = $service;
-        $this->loadTabsForObject($service);
+        $this->loadTabsForObject($this->service);


IMO this change is not required.

I have reverted it.

raviks789 · 2024-12-16T17:19:17Z

application/controllers/ServiceController.php

+                'name'                                  => t('Name'),
+                'severity desc, last_state_change desc' => t('Severity'),
+                'state'                                 => t('Current State'),
+                'last_state_change desc'                => t('Last State Change')


As mentioned in my comment in HostController::childrenAction, you could also use $this->translate() method instead as you have done in parentsAction for translation.

raviks789 · 2024-12-17T09:06:21Z

application/controllers/ServiceController.php

+                    Filter::equal('service_id', $this->service->id),
+                    Filter::equal('host_id', $this->service->host_id)
+                ))
+                ->first() !== null;


IMO, you could either ignore this strict comparison, or you could use ->execute()->hasResult() that would return boolean.

raviks789 · 2024-12-17T09:15:31Z

application/controllers/HostController.php

+        if ($hasDependencyNode) {
+            $tabs->add('parents', [
+                'label' => t('Parents'),
+                'url'   => Url::fromPath('icingadb/host/parents', ['name' => $this->host->name])


As mentioned earlier, you could create and use Link::hostParents method.

As discussed offline, Link class should not be used here.

raviks789 · 2024-12-17T09:34:11Z

public/css/list/redundancy-group-list-item.less

+    .title > * {
+      margin: 0 .28125em; // 0 calculated &nbsp; width
+
+      &:first-child {
+        margin-left: 0;
+      }
+
+      &:last-child {
+        margin-right: 0;
+      }
+    }


This rule is already applied in ipl-web item-list.less. Is there a reason why you are doing this here again?

- Otherwise the searchbar uses it as base filter and apply it on the query

- Set the outer tab as active. Previously, the inner tab was activated in the setTitleTab method, but the outer tab does not know about the state of inner tabs. So whenever sendMultipartUpdate() -> getActiveTab() was called, the retured value was always null.

sukhwinder33445 self-assigned this Nov 25, 2024

sukhwinder33445 changed the base branch from main to dependencies November 25, 2024 14:19

sukhwinder33445 requested a review from nilmerg November 26, 2024 07:52

sukhwinder33445 force-pushed the introduce-parents-children-tab branch from 59dc8c9 to 74bb945 Compare December 5, 2024 10:16

cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Dec 5, 2024

nilmerg linked an issue Dec 9, 2024 that may be closed by this pull request

List views for parents and children #1063

Open

nilmerg requested changes Dec 9, 2024

View reviewed changes

sukhwinder33445 force-pushed the introduce-parents-children-tab branch 2 times, most recently from c37ece0 to 9ab8072 Compare December 16, 2024 09:21

raviks789 reviewed Dec 17, 2024

View reviewed changes

sukhwinder33445 force-pushed the introduce-parents-children-tab branch from 9ab8072 to fb557c7 Compare December 18, 2024 12:00

sukhwinder33445 added 8 commits December 18, 2024 17:25

(Host|Service)Controller: Let the init() render the object header

135f8b1

(Host|Service)Controller: Add parents and children tab

f00d507

(Host|Service)Controller: Shift the required param

ef6ab1f

- Otherwise the searchbar uses it as base filter and apply it on the query

(Host|Service)Controller: Add return type to methods

e4eac27

Add view mode functionality for RedundancyGroup items

518090e

Add csv/json export support for parents and children tab

ae3b36a

Don't show parents children tab if icingadb.schema version < 6

03a160d

sukhwinder33445 force-pushed the introduce-parents-children-tab branch from fb557c7 to 03a160d Compare December 18, 2024 16:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(Host|Service) Detail view: Introduce parents and children tab #1098

(Host|Service) Detail view: Introduce parents and children tab #1098

sukhwinder33445 commented Nov 25, 2024

nilmerg left a comment

raviks789 commented Dec 16, 2024

raviks789 Dec 16, 2024

sukhwinder33445 Dec 18, 2024

raviks789 Dec 16, 2024

raviks789 Dec 16, 2024

sukhwinder33445 Dec 18, 2024

raviks789 Dec 16, 2024

raviks789 Dec 16, 2024

raviks789 Dec 16, 2024

sukhwinder33445 Dec 18, 2024

raviks789 Dec 16, 2024

raviks789 Dec 17, 2024

raviks789 Dec 17, 2024

sukhwinder33445 Dec 18, 2024

raviks789 Dec 17, 2024

(Host|Service) Detail view: Introduce parents and children tab #1098

Are you sure you want to change the base?

(Host|Service) Detail view: Introduce parents and children tab #1098

Conversation

sukhwinder33445 commented Nov 25, 2024

nilmerg left a comment

Choose a reason for hiding this comment

raviks789 commented Dec 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment