Restrictions #159
Merged
Restrictions #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
force-pushed
the
feature/restrictions
branch
4 times, most recently
from
f6baa8b to
811002a
Compare
Merged
Previously, also service comments were counted.
Previously also service comments and downtimes were shown.
… usergroup listings
Otherwise not all hostgroups are shown if there's a host restriction active
Otherwise not all servicegroups are shown if there's a service restriction active
...and not with as much queries as there are notifications*recipients
nilmerg
force-pushed
the
feature/restrictions
branch
from
811002a to
e9d132a
Compare
nilmerg
force-pushed
the
feature/restrictions
branch
from
25e3033 to
6eeaf39
Compare
This is a preparation for the custom variable restrictions as they're supposed to be applied on the query.
nilmerg
force-pushed
the
feature/restrictions
branch
2 times, most recently
from
9d62bac to
0920fbe
Compare
This depends upon Icinga/ipl-orm#13
nilmerg
force-pushed
the
feature/restrictions
branch
from
3f9a382 to
aae4c01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following restrictions:
icingadb/filter/objects(Applies to all objects)icingadb/filter/hosts(Applies to hosts and services)icingadb/filter/services(Applies only to services)icingadb/blacklist/variables(Hides custom variables)icingadb/protect/variables(Obfuscates custom variables with***)Why is
icingadb/filter/hostsalso to services applied? Because if you can access a host, you might not access all services as a host can exist without any service. A service however can't exist without a host and therefore, if you can't access the host, you can't access its services.refs Icinga/icingaweb2#3349
refs Icinga/icingaweb2#3550