SearchControls: Add available $preserveParams as default to (SearchBar/SearchEditor)suggestionUrl
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
added a commit
to Icinga/icingadb-web
that referenced
this pull request
Oct 21, 2024
…ditor) suggestionUrl SuggestionUrl now uses the preserveParams as default params ref: Icinga/ipl-web#233
sukhwinder33445
added a commit
to Icinga/icingadb-web
that referenced
this pull request
Oct 21, 2024
…ditor) suggestionUrl SuggestionUrl now uses the preserveParams as default params require: Icinga/ipl-web#233
nilmerg
requested changes
Oct 28, 2024
sukhwinder33445
force-pushed
the
add-preserve-params-as-default-params-for-suggestion-url
branch
2 times, most recently
from
58ff9b1 to
c676507
Compare
…r/SearchEditor)suggestionUrl
sukhwinder33445
force-pushed
the
add-preserve-params-as-default-params-for-suggestion-url
branch
from
2acb77c to
f848e9b
Compare
nilmerg
approved these changes
Nov 13, 2024
nilmerg
deleted the
add-preserve-params-as-default-params-for-suggestion-url
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we no longer have to set the suggestionUrl manually, as in (Host/Service)groupController