initialize SegmentLabel from SegmentDescription #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without SegmentLabel in JSON, dcmqi currently uses the heuristic to populate it from SegmentedPropertyTypeCodeSequence>CodeMeaning, which is suboptimal, since it does not take into account laterality. At the same time, SegmentLabel is used both by OHIF and Slicer (see https://github.com/QIICR/QuantitativeReporting/blob/master/DICOMPlugins/DICOMSegmentationPlugin.py#L202) to initialize segment names shown to the user. Related to this PR that will revisit the heuristic used by dcmqi, and use SegmentDescription if SegmentLabel is not available before defaulting to segmented property type code meaning: QIICR/dcmqi#488
|
I loaded a sample seg into slicer and it looks good. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without SegmentLabel in JSON, dcmqi currently uses the heuristic to populate it from SegmentedPropertyTypeCodeSequence>CodeMeaning, which is suboptimal, since it does not take into account laterality. At the same time, SegmentLabel is used both by OHIF and Slicer (see https://github.com/QIICR/QuantitativeReporting/blob/master/DICOMPlugins/DICOMSegmentationPlugin.py#L202) to initialize segment names shown to the user. Related to this PR that will revisit the heuristic used by dcmqi, and use SegmentDescription if SegmentLabel is not available before defaulting to segmented property type code meaning: QIICR/dcmqi#488