-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add download study dialog by adding ohif-idc-extension #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good! You will need to add/install the extension to the package.json of the app folder since the link is just virtual (local). Here:
ViewersV3/platform/app/package.json
Line 64 in 26a8ff5
"@ohif/extension-cornerstone-dicom-sr": "3.9.0-beta.74", |
Also, since we are not using a publish npm package you need to point to the other repo's main branch e.g.
ViewersV3/platform/app/package.json
Line 51 in 26a8ff5
"ohif-gcp-extension": "https://github.com/ImagingDataCommons/ohif-gcp-extension#main", |
@igoroctaviano I believe it's good to go now. Please check. |
Related to OHIF#4367 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pedrokohler lets wait Andrey to test it before merge. |
Can you please include the updated screenshots, after the PR above is merged, since I expect the UI is different than in the original screenshot at the top of this thread? Also, for the popup text, instead of "install the idc cli", can you please put "install the idc-index python package"? |
The changes above were pushed. |
LGTM Pedro! If you can, could you hyperlink idc-index? This way the user can easily learn more about the package before installing it. If hyperlinking is not straightforward, it's fine with me to merge as is! |
Context
Solves #62
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment