Compress stringify package #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewtex
force-pushed
the
compress-stringify-package
branch
from
f57ceb8
to
b908abf
Compare
thewtex
force-pushed
the
compress-stringify-package
branch
2 times, most recently
from
dfd2d34
to
e06d0e0
Compare
thewtex
force-pushed
the
compress-stringify-package
branch
6 times, most recently
from
65555b8
to
29d586b
Compare
Be consistent with the toolchain image name. BREAKING_CHANGE: The default itkwasm CLI build directory is `emscripten-build` instead of `web-build`.
For consistency.
Enable on GitHub Pages, etc.
And put the resources in their own directory.
thewtex
force-pushed
the
compress-stringify-package
branch
from
c6c7bbe
to
7fad14e
Compare
|
This branch is too large to reasonably request a review, but pinging to bring awareness:
There is more to do, and I am sure there are many improvements we can make, but leaving that for follow-up PRs. Suggestions and improvements are welcome! |
Also update itk-wasm.
PaulHax
approved these changes
Jan 18, 2023
| if (NOT TARGET libzstd_static) | ||
| include(${CMAKE_CURRENT_SOURCE_DIR}/BuildZstd.cmake) | ||
| endif() | ||
| include(${CMAKE_CURRENT_SOURCE_DIR}/BuildZstd.cmake) |
There was a problem hiding this comment.
The packages/compress-stringify/BuildZstd.cmake file is duplicated in the top level Cmake directory. Is that something to avoid?
There was a problem hiding this comment.
Good catch 🦅 👁️ !
Yes, in general we should avoid this duplication.
We have some refactoring to do before consolidation, tracked in #716
Wonderful! 🎉 |
|
🎉 This PR is included in version 1.0.0-b.59 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.