Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package refactoring #716

Open
thewtex opened this issue Jan 19, 2023 · 5 comments
Open

Package refactoring #716

thewtex opened this issue Jan 19, 2023 · 5 comments
Milestone
v1.0.0

Comments

@thewtex
Copy link
Member

thewtex commented Jan 19, 2023 •
edited
Loading

Refactor into packages/:

1.@itk-wasm/dicom (currently in dist/), then incorporate the ./io/internal/pipelines/image/read-dicom/CMakeLists.txt
2. @itk-wasm/image-io
3. @itk-wasm/mesh-io
4. @itk-wasm/polydata-io - no longer supported
6. @itk-wasm/mesh-to-polydata (migrate to remote module repository)
7. Migrate src/core -> itk-wasm

Then consolidate duplication when possible, e.g. BuildZstd.cmake.

Then configuration as a npm/pnpm workspace.
@thewtex thewtex added this to the 1.0.0 milestone Jan 19, 2023
@thewtex thewtex mentioned this issue Jan 19, 2023
Merged
@thewtex
Copy link
Member Author

thewtex commented May 8, 2023

  1. addressed via Dicom image package #828

@thewtex thewtex mentioned this issue May 8, 2023
Closed
@thewtex
Copy link
Member Author

thewtex commented Oct 11, 2023

  1. partially addressed via Migrate image io pkg #741

@thewtex thewtex mentioned this issue Nov 13, 2023
Closed
@thewtex
Copy link
Member Author

thewtex commented Nov 29, 2023

  1. partially addressed via Mesh io package #1009

@thewtex
Copy link
Member Author

thewtex commented Nov 30, 2023

  1. partially addressed in Wasm packages ITKMeshToPolyData#59

@thewtex
Copy link
Member Author

thewtex commented Dec 6, 2023

  1. and pnpm workspace partially addressed in Core package #1010

thewtex added a commit to thewtex/ITK-Wasm that referenced this issue Dec 14, 2023
@thewtex
refactor: migrate deprecated module shims into the core package
277c6c3 
Following InsightSoftwareConsortium#716

BREAKING_CHANGE: readDICOMTags has been migrated to @itk-wasm/dicom and as readDicomTags
BREAKING_CHANGE: readDICOMTagsArrayBuffer has been migrated to @itk-wasm/dicom and as readDicomTags
BREAKING_CHANGE: readDICOMTagsLocalFile has been migrated to @itk-wasm/dicom and as readDicomTagsNode
BREAKING_CHANGE: readImageDICOMFileSeries has been migrated to @itk-wasm/dicom as readImageDicomFileSeries
BREAKING_CHANGE: readImageDICOMArrayBufferSeries has been migrated to @itk-wasm/dicom as readImageDicomFileSeries
BREAKING_CHANGE: readImageLocalDICOMFileSeries has been migrated to @itk-wasm/dicom as readImageDicomFileSeriesNode
thewtex added a commit to thewtex/ITK-Wasm that referenced this issue Dec 14, 2023
@thewtex
refactor: deprecate mesh-to-poly-data and point to new package
e72bdb1 
Following InsightSoftwareConsortium#716

BREAKING_CHANGE: meshToPolyData, meshToPolyDataNode, polyDataToMesh, polyDataToMeshNode have been migrated to @itk-wasm/mesh-to-poly-data
This was referenced Dec 15, 2023
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@thewtex