Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate image io pkg #741

Merged
merged 43 commits into from
Oct 11, 2023
Merged

Migrate image io pkg #741

merged 43 commits into from
Oct 11, 2023

Conversation

floryst
Copy link
Member

@floryst floryst commented Jan 27, 2023

No description provided.

@thewtex thewtex mentioned this pull request Aug 16, 2023
Closed
@thewtex
Copy link
Member

thewtex commented Aug 16, 2023

rebasing on main and re-starting migration

@netlify
Copy link

netlify bot commented Aug 16, 2023 •
edited
Loading

✅ Deploy Preview for itk-wasm-docs ready!

Name Link
🔨 Latest commit 482433f
🔍 Latest deploy log https://app.netlify.com/sites/itk-wasm-docs/deploys/64de144d297d3100078ee7e5
😎 Deploy Preview https://deploy-preview-741--itk-wasm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thewtex
Copy link
Member

thewtex commented Aug 17, 2023

Building on @floryst 's work here and adding @aylward 's suggestion, we support asking all ITK image-io's for information-only, calling the IO's ReadImageInformation(), to get the metadata separately.

This can be exposed in itk-viewer/io in an ItkImageIoMultiscaleSpatialImage, similar to a DicomSeriesMultiscaleSpatialImage suggested by @floryst and the ZarrMultiscaleSpatialImage implemented by @PaulHax .

@thewtex thewtex force-pushed the migrate-image-io-pkg branch 3 times, most recently from fc0be05 to 7d41d5a Compare August 28, 2023 02:04
floryst and others added 10 commits October 2, 2023 21:31
@floryst @thewtex
feat(image-io): initial image-io pkg sources
376e70f
@floryst @thewtex
fix: add image-io cxx sources
f4ff5eb
@floryst @thewtex
fix(image-io): import localPathRelativeToModule
3dcd325
@thewtex
feat(image-io): Update package for bindgen generation
da20f7e
@thewtex
build(image-io): Add wasi and bindgen build scripts
c53a029
@thewtex
build(image-io): Update package.json based on bindgen
34d9762
@thewtex
feat(image-io): Add --information-only flag
564e678 
Support only reading and writing image metadata as opposed to pixel
data.

Also output whether an IO can read or write a image with a json output
that contains a boolean.
@thewtex
refactor(image-io): Remove old manual typescript interfaces
f16eb05
@thewtex
feat(image-io): Mark typescript couldRead and couldWrite as booleans
5b4c63a 
Edit commands:

```sh
cd packages/image-io/typescript
git sed 's/couldRead: Object/couldRead: boolean/'
git sed 's/couldWrite: Object/couldWrite: boolean/'
for ff in src/*result*; do tail -n+3 $ff > "${ff}.new"; mv "${ff}.new" $ff ; done
git sed 's/JsonObject).data/JsonObject).data as boolean/'
```
@thewtex
refactor(image-io): use generated typescript sources
354deac
@thewtex thewtex force-pushed the migrate-image-io-pkg branch 2 times, most recently from 1440b18 to 4ab15cc Compare October 10, 2023 01:10
@thewtex thewtex marked this pull request as ready for review October 10, 2023 20:18
@thewtex thewtex merged commit 912f008 into main Oct 11, 2023
128 checks passed
@thewtex thewtex deleted the migrate-image-io-pkg branch October 11, 2023 14:53
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-b.147 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thewtex thewtex mentioned this pull request Oct 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floryst @thewtex