Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds device keyword argument to astype #1511

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

ndgrigorian
Copy link
Collaborator

This pull request implements the device keyword into dpctl.tensor.astype, which permits simultaneously casting and sending the array to a separate device.

The type of the array must be supported on the new device, as well as the type it is being cast to.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

@coveralls
Copy link
Collaborator

coveralls commented Jan 26, 2024

Coverage Status

coverage: 90.92% (-0.05%) from 90.974%
when pulling ceb3961 on device-aware-astype
into 8f82fe1 on master.

Copy link

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_33 ran successfully.
Passed: 908
Failed: 1
Skipped: 86

Copy link

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_33 ran successfully.
Passed: 909
Failed: 0
Skipped: 86

Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @ndgrigorian !

@ndgrigorian ndgrigorian merged commit 6ad006e into master Jan 26, 2024
46 of 50 checks passed
@ndgrigorian ndgrigorian deleted the device-aware-astype branch January 26, 2024 15:38
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants