Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added device keyword argument to astype function #1870

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Added device keyword argument to astype function #1870

merged 4 commits into from
Jun 14, 2024

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Jun 7, 2024 •
edited
Loading

DPCTL implemented device keyword into dpctl.tensor.astype, which permits simultaneously casting and sending the array to a separate device in PR#1511.

Added device keyword to astype function in DPNP.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Jun 7, 2024
View reviewed changes
tests/test_sycl_queue.py Outdated Show resolved Hide resolved
dpnp/dpnp_array.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4, no more comments from me.

@antonwolfy antonwolfy merged commit 38fd39d into master Jun 14, 2024
48 of 56 checks passed
@antonwolfy antonwolfy deleted the astype_device branch June 14, 2024 18:07
github-actions bot added a commit that referenced this pull request Jun 14, 2024
@github-actions
Added device keyword argument to astype function (#1870)
0894e5b 
* Added device keyword argument to astype function

* Added test for astype function

* address comments

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 38fd39d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy