Update dpnp tests to run on Iris Xe #1294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oleksandr-pavlyk @antonwolfy what do you think about this solution? |
oleksandr-pavlyk
changed the title
|
Test should check for the aspect of the device where the array has been allocated, not of the default-selected device. |
antonwolfy
reviewed
Feb 16, 2023
tests/test_absolute.py
Outdated
| def test_abs_int(type): | ||
| a = numpy.array([1, 0, 2, -3, -1, 2, 21, -9]) | ||
| @pytest.mark.parametrize( | ||
| "dtype", get_all_dtypes(no_bool=True, no_none=True, no_complex=True) |
There was a problem hiding this comment.
I guess it might be helpful to check with default dtype also.
Suggested change
| "dtype", get_all_dtypes(no_bool=True, no_none=True, no_complex=True) | |
| "dtype", get_all_dtypes(no_bool=True, no_complex=True) |
tests/test_flat.py
Outdated
| @pytest.mark.parametrize("type", | ||
| [numpy.int64], | ||
| ids=['int64']) | ||
| @pytest.mark.parametrize("type", [numpy.int64], ids=["int64"]) |
There was a problem hiding this comment.
Looks type is never used in the test
5 tasks
vlad-perevezentsev
force-pushed
the
support_dpnp_tests_on_iris
branch
from
3a6990a to
83deb0d
Compare
vlad-perevezentsev
force-pushed
the
support_dpnp_tests_on_iris
branch
from
83deb0d to
d72d400
Compare
|
@vlad-perevezentsev, do we need still the PR or it can be rejected? |
|
I will close this PR cause all tests here have been updated with #1472 and other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue #1293
This PR adds a new skip_or_change_if_dtype_not_supported function to helper.py and fixes some tests to run them on Iris Xe which does not support double precision floating point type.
The new function is needed to change an unsupported type to a supported type and skip text if necessary.
Also this PR uses black 22.6.0 for tests.
Needed to create new PRs and fix the code of function directly for the rest of the tests.