Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some of the dpnp tests to run on Iris Xe #1472

Merged
merged 13 commits into from
Jul 31, 2023
Merged

Update some of the dpnp tests to run on Iris Xe #1472

merged 13 commits into from
Jul 31, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev commented Jul 7, 2023 •
edited
Loading

This PR solves the issue #1293

This PR fixes some tests to run them on Iris Xe which does not support double precision floating point type.
Updated tests: test_amin_amax.py, test_arraycreation.py, test_dparray, test_fft, test_histograms , test_indexing , test_sort and test_special

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jul 7, 2023
@vlad-perevezentsev vlad-perevezentsev changed the title Update dpnp tests to run on Iris Xe Update some of the dpnp tests to run on Iris Xe Jul 27, 2023
@vlad-perevezentsev vlad-perevezentsev marked this pull request as ready for review July 27, 2023 13:11
antonwolfy
antonwolfy reviewed Jul 31, 2023
View reviewed changes
tests/helper.py Outdated Show resolved Hide resolved
tests/test_amin_amax.py Show resolved Hide resolved
tests/test_amin_amax.py Outdated Show resolved Hide resolved
tests/test_arraycreation.py Outdated Show resolved Hide resolved
tests/test_dparray.py Outdated Show resolved Hide resolved
tests/test_dparray.py Outdated Show resolved Hide resolved
tests/test_fft.py Show resolved Hide resolved
tests/test_indexing.py Outdated Show resolved Hide resolved
tests/test_sort.py Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes! A lot of the tests are passing on Iris Xe now. Thank you @vlad-perevezentsev

@antonwolfy antonwolfy merged commit 3c0f249 into IntelPython:master Jul 31, 2023
@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Aug 30, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderKalistratov AlexanderKalistratov AlexanderKalistratov left review comments

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlad-perevezentsev @AlexanderKalistratov @antonwolfy