Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dpnp.searchsorted #1751

Merged
merged 8 commits into from
Mar 26, 2024
Merged

Implement dpnp.searchsorted #1751

merged 8 commits into from
Mar 26, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 20, 2024 •
edited
Loading

The PR is about to implement dpnp.searchsorted through leveraging on dpctl implementation.
In addition, the PR adds missing dpnp.ndarray.searchsorted method and increases tests coverage.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Mar 20, 2024
@antonwolfy
Copy link
Contributor Author

antonwolfy commented Mar 20, 2024 •
edited
Loading

Currently, the tests are failing due to IntelPython/dpctl#1598 and IntelPython/dpctl#1599.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy mentioned this pull request Mar 21, 2024
Merged
6 tasks
vlad-perevezentsev
vlad-perevezentsev approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 09e7e33 into master Mar 26, 2024
45 checks passed
@antonwolfy antonwolfy deleted the impl-searchsorted branch March 26, 2024 12:42
github-actions bot added a commit that referenced this pull request Mar 26, 2024
@github-actions
Implement dpnp.searchsorted (#1751)
5599870 
* Implement dpnp.searchsorted

* Stated explicit wrapping behavior of out of bound values of sorter per dpctl spec

* Muted previously enabled overflow tests

* Corrected test_argsort_ndarray test with unique generated random values 09e7e33
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Mar 26, 2024
@github-actions
Implement dpnp.searchsorted (IntelPython#1751)
505a0e2 
* Implement dpnp.searchsorted

* Stated explicit wrapping behavior of out of bound values of sorter per dpctl spec

* Muted previously enabled overflow tests

* Corrected test_argsort_ndarray test with unique generated random values 09e7e33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev