call dpnp.kron and dpnp.dot for special cases in dpnp_matmul
#1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
reorganizing for easier future code development calling dpnp.kron and dpnp.dot for special cases in dpnp.matmul
vtavana
force-pushed
the
update-dpnp_matmul
branch
from
c8056e0
to
d4ff047
Compare
vtavana
changed the title
dpnp.kron and dpnp.dot for special cases in dpnp_matmul
antonwolfy
reviewed
May 13, 2024
antonwolfy
reviewed
May 14, 2024
github-actions bot
added a commit
that referenced
this pull request
May 14, 2024
…1815) * reorganize the structure of dpnp_matmul function reorganizing for easier future code development calling dpnp.kron and dpnp.dot for special cases in dpnp.matmul * address comments * improve coverage * fix pre-commit --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> e1dcc45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check #1844 for a correction to this PR.
In this PR,
dpnp.kronanddpnp.dotare being called for special cases ofdpnp.matmul.In addition,
dpnp_matmulis re-organized to better serve for future code development..