Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gh-1843 #1844

Merged
merged 2 commits into from
May 22, 2024
Merged

fix gh-1843 #1844

merged 2 commits into from
May 22, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented May 22, 2024

This PR fixes a mistake made in #1815 and address issue #1843

>>> import dpnp
>>> dpnp.linalg.pinv(dpnp.zeros((2,1,1), dtype="f4"))
# array([[[0.]],
#       [[0.]]], dtype=float32)

>>> a = dpnp.ones((2, 1, 1))
>>> a @ a
# array([[[1.]],
#       [[1.]]], dtype=float32)
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this May 22, 2024
Copy link
Contributor

github-actions bot commented May 22, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review May 22, 2024 02:08
@vtavana vtavana requested a review from antonwolfy May 22, 2024 02:08
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana. The issue is gone now.

@antonwolfy antonwolfy merged commit 069cad2 into master May 22, 2024
53 of 56 checks passed
@antonwolfy antonwolfy deleted the fix_gh-1843 branch May 22, 2024 11:24
github-actions bot added a commit that referenced this pull request May 22, 2024
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 069cad2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants