Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added utilities/string/chrono.h; fix test-waiting-on.cpp to use it #10762

Merged
merged 2 commits into from
Aug 14, 2022

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Aug 10, 2022

Durations do not have an operator<< unless you're in C++20, so output from test-waiting-on was not readable.
Before:

C:\jenkins_sys_rsbuild\workspace\LRS_windows_compile_pipeline\unit-tests\utilities\time\test-waiting-on.cpp(164): FAILED:
  REQUIRE( wait_time >= timeout )
with expansion:
  {?} >= {?}

After:

with expansion:
  0.005s > 1.99s

@maloel maloel requested a review from Nir-Az August 10, 2022 07:40
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Nir-Az Nir-Az merged commit 31d7702 into IntelRealSense:development Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants