restricting the D405 w/a for calibration resolution to D405 PID only #10913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Sep 18, 2022
| @@ -2014,24 +2014,27 @@ namespace rs2 | |||
| { | |||
| // checking format | |||
| bool is_cal_format = false; | |||
| for (auto it = stream_enabled.begin(); it != stream_enabled.end(); ++it) | |||
| if (dev.supports(RS2_CAMERA_INFO_PRODUCT_ID) && !strcmp(dev.get_info(RS2_CAMERA_INFO_PRODUCT_ID), "0B5B")) | |||
There was a problem hiding this comment.
-
Please add a comment about what
0B5Bmeans, magic numbers should not be used without explaining.
I would maybe add astatic const string D405_PID = "0B5B"for all D405 usage in this file -
Please explain (add a comment) why all except D405 should always return false here (I hate
strcmpreturn value :) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: LRS-517