Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsigned fw update #11604

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Mar 23, 2023

We changed the behavior and do not wait for HWM response when we don't need it (previous PR) .
Unsigned FW update process loop and send HWM byte by byte for writing the new image.
Looks like he cannot handle the write speed and the previous action bought it some time. (or it is really expecting the get command)
The process does not end without it..

I restored the old behavior on that case and it fixed the issue.
LibCI test? I think it's needed for regression.
Next PR.

Tracked on [LRS-745]

@Nir-Az Nir-Az requested a review from remibettan March 23, 2023 18:06
@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Mar 23, 2023

@remibettan , @SamerKhshiboun FYI
The first that can please review so we can merge

Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit cf4adf0 into IntelRealSense:development Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants