Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unit-test-config cmake file detection; add cmake:dependencies #12223

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Sep 26, 2023

The cmakes created for unit-tests were including unrelated files, increasing the project dependencies. Fixed.
Added some comments in the makefiles, too, to better understand where the includes came from.
Also added cmake:dependencies directive, with the idea of having some tests only depend on rsutils, for example, so they wouldn't have to build librealsense.

Tracked on [LRS-879]

Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel maloel merged commit 07c198c into IntelRealSense:development Sep 27, 2023
15 checks passed
@maloel maloel deleted the unit-test-config branch September 27, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants