Power on UVC sensors after creation to speed initialization #12897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
May 9, 2024
| { | ||
| std::this_thread::sleep_for( timeout ); | ||
| if( auto strong = weak.lock() ) | ||
| strong->release_power(); |
There was a problem hiding this comment.
Please make sure release_power(); cannot throw.
Even if today it can't might be better to wrap with try/catch as an exception here will crash the application
There was a problem hiding this comment.
release_power catches set_power_state exceptions.
Theoretically there might be an exception from locking a mutex, but I don't think we need to guard against it. If locking a mutex fails here will probably be the least of our problems.
Nir-Az
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At initialization phase there are many HWM and other commands that need the sensor to be in powered on (D0) state.
Keeping it on for a short time instead of turning it on and off (D3) can speed up the initialization.
Testing with a D500 device it reduced pipeline time to first frame by an average of 90 milliseconds.