IMU frame index jump in D457-Mipi #12965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
reviewed
May 27, 2024
OhadMeir
reviewed
May 27, 2024
Nir-Az
reviewed
May 28, 2024
src/uvc-sensor.cpp
Outdated
| //Motion stream on uvc is used only for mipi. Stream frame number counts gyro and accel together. | ||
| //We override it using 2 seperate counters. | ||
| auto pixels = (uint8_t *)f.pixels; | ||
| if( pixels[0] == 1 ) |
There was a problem hiding this comment.
Please add a comment explaining what this and the next if check?
What's inside pixels[0]?
What 1 means?
What 2 means?
Maybe use consts for that?
There was a problem hiding this comment.
auto stream_type= (uint8_t *)f.pixels[0];
if( stream_type == 1 ) // 1 == Accel
Nir-Az
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on RSDSO-19645