Fix rs terminal #1356
Merged
Fix rs terminal #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix links to OpenCV examples in readme.md
The original rs-terminal would only ever select the 0 device. If you entered "-d 1" it would still only apply the command to camera 0. Also, it relied on realsense's device numbering system which was inconsistent. Customers were unable to send commands to specific cameras programatically using something static like the serial number. I changed rs-terminal.cpp to include: -Proper selection of input devices (-d sends command to correct devices) -Ability to send a command to all connected realsense devices with -a flag -Ability to send a command to a device based on its serial number with -n flag
dorodnic
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original rs-terminal would only ever select the 0 device. If you entered "-d 1" it would still only apply the hex command to camera 0. Also, it relied on realsense's device numbering system which was inconsistent. I was unable to send commands to specific cameras programatically using something static like the serial number.
I changed rs-terminal.cpp to include:
-Bug Fix: Proper selection of input devices ("-d" sends command to correct devices)
-Feature: Ability to send a command to all connected realsense devices with "-a" flag
-Feature: Ability to send a command to a device based on its serial number with "-n" flag