Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix realsense viewer on macos #3195

Merged
merged 5 commits into from
Feb 3, 2019
Merged

Fix realsense viewer on macos #3195

merged 5 commits into from
Feb 3, 2019

Conversation

devernay
Copy link
Contributor

@devernay devernay commented Feb 1, 2019

macOS does not provide an OpenGL 3.2 compatibility profile: only OpenGL 2.1 is available.
Because of the shading langage version used (1.10), we cannot use a core profile either.
The solution is to check whether the required functionality is available, and provide fallback replacements from extensions.
There is also a clang-specific test to let the unit tests compile.

barnjamin and others added 5 commits January 23, 2019 21:23
Just the first image is saved with `jpg` lower the rest are `JPG`.
Markdown Images case sensitive
GL_APPLE_vertex_array_object or GL_ARB_vertex_array_object provide the OpenGL 3.0 functionality that is missing in Apple's OpenGL 2.1.
Apple does not provide a compatibility profile for OpenGL 3.2.
std::vector<bool>::emplace_back is not available on clang
@SHTseng
Copy link

SHTseng commented Feb 3, 2019

UI tools such realsense viewer, depth quality tool in macos get segmentation fault on the latest release. They are both work with this pull request. I tested on a 2017 mbp with macos 10.13.6, and connect the d435i to the computer via usb-c to usb-c wire.

@dorodnic
Copy link
Contributor

dorodnic commented Feb 3, 2019

Hi @devernay
Thanks for the fix, that's my bad. I was really struggling with this problem and will test the fix ASAP.
I'm trying to upstream GLSL rendering and calculation of point-cloud and other CPU consuming parts for Viewer and general use. Due to the Mac OS problem, I tried to roll-back all usages of GLSL for last release, but must have missed one.

@dorodnic dorodnic changed the base branch from master to development February 3, 2019 15:05
@dorodnic
Copy link
Contributor

dorodnic commented Feb 3, 2019

Worked like a charm 👍 I completely missed that glad script can generate extensions in this way.
Also, tested this PR on Ubuntu and Windows 10.

I'm not sure why emplace_back was giving trouble, AFAIK it should compile with most recent versions of clang, and we do have clang 9.1 in Travis. But push_back is equally good.

@dorodnic dorodnic merged commit 1bbc4d7 into IntelRealSense:development Feb 3, 2019
@dorodnic
Copy link
Contributor

dorodnic commented Feb 3, 2019

One more thing - I retargeted the PR to the development branch, as it is our staging area prior to release.
(see CONTRIBUTING.md)
Obviously, we will work to get master back to stable state ASAP, but it will be easier for us if everything is merged to dev first.

@dorodnic dorodnic added the MacOS label Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants