Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencv: only use the C++ API #3196

Merged
merged 1 commit into from
Feb 6, 2019
Merged

opencv: only use the C++ API #3196

merged 1 commit into from
Feb 6, 2019

Conversation

devernay
Copy link
Contributor

@devernay devernay commented Feb 1, 2019

This is a more complete version of #3091 which completely gets rid of the C API usage.
Note that the C++ API used in this PR was already available in OpenCV 2.4.

@devernay
opencv: only use the C++ API
96768d3 
fixes build with OpenCV 4.0
@dorodnic
Copy link
Contributor

dorodnic commented Feb 3, 2019

Thanks @devernay
Tested with latest opencv. I'm looking into some (new?) issue in rs-grabcuts. Will update once everything is stable.

@dorodnic dorodnic added the opencv label Feb 3, 2019
@dorodnic
Copy link
Contributor

dorodnic commented Feb 6, 2019

Ok, the rs-grabcut example was a false alarm (bad calibration and USB2), everything else worked really well, thank you @devernay and @s-trinh!

@dorodnic dorodnic changed the base branch from master to development February 6, 2019 08:53
@dorodnic dorodnic merged commit 8dddda1 into IntelRealSense:development Feb 6, 2019
@dorodnic dorodnic mentioned this pull request Feb 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorodnic dorodnic dorodnic approved these changes

Assignees
No one assigned
Labels
opencv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devernay @dorodnic