Replace vec2mat with reshape #2 #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #2708 had suggested replacing
vec2matfunction withreshapefunction in depth_example.m file under MATLAB wrapper folder. This request was accepted and was merged.The code of depth_example.m also appears in the readme.md file located at the same folder, however the
vec2matfunction still remains in the code under the readme.md file. To keep the consistency of code, and also to minimise the use of existing MATLAB toolboxs, I suggest changingvec2matfunctions toreshapefunction in the readme.md file, just like how it was changed in depth_example.m file.