API for adding software device into existing context #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 530d17b)
ev-mp
reviewed
Feb 27, 2019
src/software-device.cpp
Outdated
| @@ -195,6 +202,8 @@ namespace librealsense | |||
|
|
|||
| void software_sensor::on_video_frame(rs2_software_video_frame software_frame) | |||
| { | |||
| if (!_is_streaming) return; | |||
There was a problem hiding this comment.
Can you add it to software_sensor::on_motion_frame(... ? Seem to be missing as well
| @@ -239,6 +239,13 @@ namespace rs2 | |||
|
|
|||
| return software_sensor(sensor); | |||
| } | |||
|
|
|||
| void inject_to(context ctx) | |||
src/context.h
Outdated
| @@ -131,6 +131,7 @@ namespace librealsense | |||
|
|
|||
| std::shared_ptr<device_interface> add_device(const std::string& file); | |||
| void remove_device(const std::string& file); | |||
| void add_device(std::shared_ptr<device_info> software_device); | |||
There was a problem hiding this comment.
This may be confusing with the definition 2 lines above.
Maybe add_software_device - will also be consistent with internal rs2_context_add_software_device
|
Updated |
dorodnic
force-pushed
the
add_software_device
branch
from
cef0514
to
4811632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds function on context that can take instance of
software_deviceand report it later fromquery_devices.This opens two possibilities:
a. Make
pipelinework withsoftware_deviceb. Make the Viewer visualize
software_device(by adding it tocontextin ViewermainUltimately, this is good for all kinds of importers - software device can be used to implement converters from other file formats, but also convert other live sensors into librealsense sensors.