android - add presets support, enable camera stream configuration #3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-mp
reviewed
Apr 17, 2019
src/android/jni/advanced_mode.cpp
Outdated
| Java_com_intel_realsense_librealsense_Device_nSerializePresetToJson(JNIEnv *env, jclass type, | ||
| jlong handle) { | ||
| rs2_error* e = NULL; | ||
| rs2_raw_data_buffer* raw_data_buffer = rs2_serialize_json( |
There was a problem hiding this comment.
The raw_data_buffer should probably be wrapped in RAII in order jByteArray will throw.
Check the implementation for std::vector<uint8_t> send_and_receive_raw_data(con in rs_device.hpp
src/android/usb_host/usb_pipe.cpp
Outdated
| for(int i = 0; i < response->actual_length; i++) | ||
| buff += ", " + std::to_string(((uint8_t*)response->buffer)[i]); | ||
| LOG_DEBUG("interrupt_request: " << buff.c_str()); | ||
| if(response->actual_length == 6){ |
There was a problem hiding this comment.
Replace all the hard-coded codes with enum for maintainability
| long[] streamProfilesHandles = nGetStreamProfiles(mHandle); | ||
| List<StreamProfile> rv = new ArrayList<>(); | ||
| for(long h : streamProfilesHandles){ | ||
| rv.add(new VideoStreamProfile(h));// TODO check if extendable |
There was a problem hiding this comment.
Put provision for motion sensor
src/android/usb_host/usb_pipe.cpp
Outdated
| 0x01, //CLEAR_FEATURE | ||
| 0, _endpoint.get_endpoint_address(), NULL, 0, 10) == UVC_SUCCESS; | ||
| 0x01, //CLEAR_FEATURE | ||
| 0, _endpoint.get_endpoint_address(), NULL, 0, 10) == UVC_SUCCESS; |
ev-mp
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables depth presets via Java Android wrapper.
It also contains new features to the Android camera app:
Tracked on: DSO-12447