Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Wrapper Options #4666

Merged
merged 4 commits into from
Aug 20, 2019
Merged

Sync Wrapper Options #4666

merged 4 commits into from
Aug 20, 2019

Conversation

radfordi
Copy link
Contributor

This brings the wrappers up to date with the latest rs2_options.

@radfordi radfordi mentioned this pull request Aug 19, 2019
Closed
@dorodnic
Copy link
Contributor

Thank you @radfordi
I restarted the C# build as it seems like a false alarm.
Node.js build gave ReferenceError: RS2_OPTION_STREAM_FILTER is not defined which I need to understand. It's a shame original contributors of the node.js wrappers are no longer active in the community.
Within the active team @aangerma and @arilowen have some experience with that wrapper.

@radfordi
Copy link
Contributor Author

Node.js build gave ReferenceError: RS2_OPTION_STREAM_FILTER is not defined

Oops, I missed the leading RS2..

@radfordi radfordi force-pushed the sync-options branch 3 times, most recently from 15c5e9f to 23e1871 Compare August 19, 2019 21:03
@dorodnic dorodnic merged commit 9ee4317 into IntelRealSense:development Aug 20, 2019
@dorodnic dorodnic mentioned this pull request Dec 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorodnic dorodnic dorodnic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radfordi @dorodnic