PLY options #4906
PLY options #4906
Conversation
… save_to_ply callback
| class save_to_ply : public filter | ||
| { | ||
| public: | ||
| save_to_ply(std::string filename = "RealSense Pointcloud ", pointcloud pc = pointcloud()) | ||
| : filter([this](frame f, frame_source& s) { func(f, s); }), | ||
| static const auto OPTION_IGNORE_COLOR = rs2_option(RS2_OPTION_COUNT + 1); |
There was a problem hiding this comment.
Pls sync with @aangerma to avoid conflicts.
This needs to be managed cross-SDK
| filter([this](frame f, frame_source& s) | ||
| { | ||
| std::vector<rs2::frame> frame_vec; | ||
| auto tex = owner->get_last_texture()->get_last_frame(true); |
There was a problem hiding this comment.
Pls check whether the capture is safe if device is disconnected while processing the export
| @@ -83,7 +100,7 @@ namespace rs2 | |||
| //ImGui::End(); | |||
| } | |||
|
|
|||
| void viewer_model::show_3dviewer_header(ImFont* font, rs2::rect stream_rect, bool& paused, std::string& error_message) | |||
| void viewer_model::show_3dviewer_header(ImFont* large_font, ImFont* font, rs2::rect stream_rect, bool& paused, std::string& error_message) | |||
There was a problem hiding this comment.
PLs add a comment what is the 2nd font for
common/viewer.cpp
Outdated
| } | ||
|
|
||
| auto curr_exporter = exporters.find(tab); | ||
| assert(curr_exporter != exporters.end()); // every tab should have a corresponding exporter |
There was a problem hiding this comment.
The assert will be discarded in release. A run-time error should probably be generated here
common/viewer.cpp
Outdated
| { | ||
| auto curr_exporter = exporters.find(tab); | ||
| assert(curr_exporter != exporters.end()); // every tab should have a corresponding exporter | ||
| if (auto ret = file_dialog_open(save_file, curr_exporter->second.filters.c_str(), NULL, NULL)) |
common/viewer.cpp
Outdated
| @@ -264,6 +281,193 @@ namespace rs2 | |||
| } | |||
| } | |||
|
|
|||
| ImGui::PopStyleColor(3); | |||
There was a problem hiding this comment.
It is strange that the section starts with pop and not push - seem to indicate and issue elsewhere.
Please encapsulate this fragment into a function call for maintainability.
common/viewer.cpp
Outdated
| } | ||
|
|
||
| export_frame(fname, std::move(exporter), not_model, data); | ||
| exporter.reset(); |
There was a problem hiding this comment.
Why do you need to reset it explicitly just before scoping out ?
| @@ -2493,6 +2681,11 @@ namespace rs2 | |||
| return false; | |||
| } | |||
|
|
|||
| std::shared_ptr<texture_buffer> viewer_model::get_last_texture() | |||
There was a problem hiding this comment.
This seem to be a public member - what is the getter for ?
There was a problem hiding this comment.
last_texture is private
|
Superseded by #5110 |
Added PLY configuration options:
OPTION_PLY_MESH: iftrue, export mesh (calculate faces); otherwise export only points.Default:
true.OPTION_PLY_BINARY: iftrue, export binary file; otherwise export textual (ascii format) PLY.Default:
true.OPTION_PLY_NORMALS: iftrue, add vertex normals (available only whenOPTION_PLY_MESHistrue).Default:
false.The options are available in the
rs2::save_to_plyprocessing block.Also, realsense viewer now uses the above mentioned processing block when exporting to PLY. Clicking on the "floppy" button allows choosing the PLY configuration.
solves: #4813