-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLY export #5110
Merged
Merged
PLY export #5110
Changes from 22 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
86bde93
Added ply configuration: meshing / points in viewer
AnnaRomanov aaf50eb
Added binary / textual format for PLY in viewer
AnnaRomanov 8a893e5
Addded options to ply callback
AnnaRomanov 9d2df5b
Use save_to_ply processing block in viewer, some fixes in the process…
AnnaRomanov 4a2a6b0
moved frame allocator processing block to a new filter class
AnnaRomanov 0652311
added normals to ply
AnnaRomanov b432726
fix normals export, changed to generic code for file exporters in viewer
AnnaRomanov 37b93dd
back to original export_to_ply function, options are now supported in…
AnnaRomanov a164a90
fix default option values, remove unnecessary comments
AnnaRomanov d9336a9
merge fix
AnnaRomanov 018d11c
fix button position
AnnaRomanov 0adaea3
order change
AnnaRomanov b808ff3
for test
AnnaRomanov 5bf84dc
fix linux build
AnnaRomanov 1db327c
Fix python build, update export_to_ply python example
AnnaRomanov e858531
Fixes following code review
AnnaRomanov f94f832
Removed "ok" button and fixed issue with file dialog
AnnaRomanov eea6ebc
Added make_exporter template function which deduces char array size
AnnaRomanov 9a1f849
Change member name
AnnaRomanov dbaa4fd
Changed default encoding to binary
AnnaRomanov 65bc6ef
Adding persistent export progress notification
dorodnic 0872601
Merge remote-tracking branch 'anna/configure_ply' into configure_ply
dorodnic 4a9194d
Merge tag 'v2.30.1' into configure_ply
dorodnic edfe7ec
Code review fixes
dorodnic 5df8990
Adding treshold option to python and matlab wrappers
dorodnic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,6 +46,10 @@ namespace rs2 | |
config_file::instance().set_default(configurations::performance::show_fps, false); | ||
config_file::instance().set_default(configurations::performance::vsync, true); | ||
|
||
config_file::instance().set_default(configurations::ply::mesh, true); | ||
config_file::instance().set_default(configurations::ply::use_normals, false); | ||
config_file::instance().set_default(configurations::ply::encoding, 1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pls replace int with enum for maintainability |
||
|
||
#ifdef __APPLE__ | ||
config_file::instance().set_default(configurations::performance::font_oversample, 8); | ||
config_file::instance().set_default(configurations::performance::enable_msaa, true); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not clear what "without texture to.. means - also couldn't reproduce this flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, this is redundant today (remains from early versions where you could have pointcloud without texture)