Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensor refactoring #5111

Merged
merged 34 commits into from
Nov 15, 2019
Merged

Conversation

arilowen
Copy link
Contributor

Sensor refactoring

DSO-13626

  • Add Synthetic Sensor class.
  • Replace unpackers with processing blocks.
  • Add composite processing blocks.

alowenst01 and others added 30 commits October 23, 2019 14:17
Sensor refactoring

- Add Synthetic Sensor class.
- Replace unpackers with processing blocks.
- Add composite processing blocks.
- Move the raw source profiles modification from synthetic_sensor::open() method into
  the derived ::init_stream_profile method
- remove tabs from a few files
- Remove playback's probe and commit profile order restrictions.
Copy link
Contributor

@dorodnic dorodnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Final touches :)

include/librealsense2/h/rs_frame.h Show resolved Hide resolved
include/librealsense2/h/rs_sensor.h Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
src/context.cpp Show resolved Hide resolved
src/context.cpp Outdated Show resolved Hide resolved
src/proc/CMakeLists.txt Outdated Show resolved Hide resolved
src/sensor.cpp Outdated Show resolved Hide resolved
src/sensor.cpp Outdated Show resolved Hide resolved
<< ",BackEndTS," << std::fixed << f.backend_time
<< ",SystemTime," << std::fixed << system_time
<<" ,diff_ts[Sys-BE],"<< system_time- f.backend_time
<< " ,diff_ts[Sys-BE]," << system_time - f.backend_time
<< ",TS," << std::fixed << timestamp << ",TS_Domain," << rs2_timestamp_domain_to_string(timestamp_domain)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test new generated logs with RsView utility

src/sensor.cpp Outdated Show resolved Hide resolved
- Add new formats to wrappers.
- Remove redundant resolution data from motion frame allocation.
- Restore image-avx.
@dorodnic dorodnic merged commit 8f01035 into IntelRealSense:development Nov 15, 2019
@arilowen arilowen deleted the sensor-refactoring branch December 3, 2019 13:20
{
return {
new internal_frame_callback<T>(callback),
[](rs2_frame_callback* p) { /*p->release(); */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to why the release is commented out?
It is causing memory leaks. #6337 . #6375 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants