polling_device_watcher: fix race between construction and start #5387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Device watchers do not notify for devices that already exist when they are constructed (e.g. win_event_device_watcher), but polling_device_watcher was also not notifying if devices were added between construction and start. This aligns polling_device_watcher with win_event_device_watcher
radfordi
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device watchers do not notify for devices that already exist when they
are constructed (e.g. win_event_device_watcher), but
polling_device_watcher was also not notifying if devices were added
between construction and start. This aligns polling_device_watcher
with win_event_device_watcher