Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix what appears to be a copy/paste redundant code problem. Issue #5733 #5734

Merged
merged 3 commits into from
Feb 6, 2020
Merged

Fix what appears to be a copy/paste redundant code problem. Issue #5733 #5734

merged 3 commits into from
Feb 6, 2020

Commits on Jan 28, 2020

  1. Fix what appears to be a copy/paste redundant code problem. 

    Fix some casting issues. Looks like quite a bit of double vs float slop in this file.
    @JTrantow
    JTrantow committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    674402b View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2020

  1. Cleanup compiler warnings from zero-order. 

    Use value_rtd.empty() suggestion instead of (values_rtd.size() == 0).
Declare zo_value as double. Use doubles throughout detect_zero_order().
Added intialializers for resolutions_depth and read_baseline.
    @JTrantow
    JTrantow committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    271bf1e View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2020

  1. Remove the \\todo comment. Just use doubles. 

    Removed an unnecssary float cast.
Use +2ULL in the values.reserve((patch_r + 2UL) *(patch_r + 2UL)) line. This promotes each operand to a unsigned long long which matches the size_t used by reserved() and avoids compiler warnings.
    @JTrantow
    JTrantow committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    9532ef1 View commit details
    Browse the repository at this point in the history