Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux infrastructure fixes. Kernels v4.16+ #5751

Merged
merged 8 commits into from
Feb 3, 2020

Conversation

ev-mp
Copy link
Collaborator

@ev-mp ev-mp commented Jan 30, 2020

Fixes:

  • UVC and metadata node matching shall use non-lexicographic sort in v4l. Applicable for kernels 4.16+.
  • Enforce Video/Metadata sync by using two-stage blocking calls. This replaces I/O multiplexing to ensure the pairing of video and meta nodes payloads.
    -Check libusb return value to prevent null de-referencing and segfault.
  • Enforce Metadata polling is performed when invalid video buffer is encountered to ensure Video/Metadata node sync.
  • Fix hardware fps calculation when the frame number being reset internally by the FW, such as in SCP Overflow case.

Enhancements:

  • Make unified kernel patches for LTS v5.0 and v5.3.
  • Re-enable unattended patch by overriding patch --merge inconsistency with try/apply. Mentioned in Per-frame metadata is enabled for Accel but not Gyro #5710
  • Adjust metadata validation heuristics in SKU-neutral manner to allow for D400, SR300 and L500 md payloads.
  • Check Metadata/Video nodes buffers synchronization by comparing the kernel sequence buffers
  • Label v4l debug messages separately for fast on/off toggling

Addresses #5319, #4543
Potentially resolve or alleviates the following ROS issues 1024, 1047, 1060, 492.

Tracked on: DSO-14299

…t. Applicable for kernels 4.16+

Enforce Video/Metadata sync by using two-stage blocking calls. This replaces I/O multiplexing to ensure the pairing of video and meta nodes payloads
@ev-mp ev-mp marked this pull request as ready for review February 2, 2020 08:43
Verify that metadata extraction is performed when invalid video buffer is encountered to ensure Video/Metadata node sync
Check  Metadata/Video nodes buffers synchronization by comparing the kernel sequence buffers
Label the v4l backend debug messages separately for fast on/off toggling
…ally by the FW, such as in SCP Overflow case
@ev-mp ev-mp changed the title Linux infrastructure fixes Linux infrastructure fixes. Kernels v4.16+ Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants