Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android streamer start time increase fix #5792

Conversation

remibettan
Copy link
Contributor

@remibettan remibettan commented Feb 5, 2020

Autoclosable try added for getting device into Updateable - bug was only in the Android wrapper.

Tracked on: DS5U-4538, DSO-14302

return inst;
}

std::recursive_mutex m;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide behind lock() and unlock()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -21,8 +21,14 @@
public <T extends Sensor> T as(Extension extension) {
switch (extension){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assumes that the sensor is extendable -- need to catch and throw an error if not extendable...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

@remibettan remibettan force-pushed the android-streamer-start-time-increase-fix branch from 0691388 to 094d619 Compare February 6, 2020 07:28
@remibettan remibettan force-pushed the android-streamer-start-time-increase-fix branch from 094d619 to b44a29d Compare February 6, 2020 07:59
@ev-mp ev-mp merged commit 8c616ea into IntelRealSense:development Feb 6, 2020
@remibettan remibettan deleted the android-streamer-start-time-increase-fix branch June 23, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants