Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RealSense Device over Network #5999
RealSense Device over Network #5999
Changes from 13 commits
e059ba6
7842d76
386f041
857674f
4910930
57aa0ea
a930aa6
aa58fb2
7618f3a
2690509
6687506
5446e4c
7870a11
6f2e77a
6127ef5
84b1809
ee2c0d3
23c813a
ea3198e
81d9469
387f337
889fb17
adf3925
9f2589b
5c8658a
0a22968
658f873
7c9f20e
b2af009
b0f3874
c33d23c
fb2ab86
550b8d4
a9dd059
5682560
e136a8e
ace3a73
222f3e5
a3cafba
0ba448c
8d1de95
356cd70
7965aa8
e9e2e8d
353f5bb
40e3131
44ec262
c1358d8
68b5d82
3046273
ae7e364
d62da87
21bc8d3
cc94e87
7f16b1c
3e34392
69f5017
caf285c
622bc17
5c93165
a48f6b8
b95ba61
e4001bf
4c4cab8
4dd3bc1
5f8e20f
43c96ab
1903bbc
afeeeca
36a6a8d
a9ef411
3118073
7fb3d99
a49bd11
0f851a3
979c680
d5e5929
9794706
0ce89dc
a2d998f
f831125
4de3a07
4a9d2b6
264bbf9
9434c84
4b3964d
9495cd0
ae45b7a
dc98abe
43e1147
c3b34f4
83a9aad
35b3474
1c82112
bc81cc4
cc6c578
ad368cd
eb033c2
9fc085f
72c353b
b758ae7
58ae051
9f013ce
b829226
ea34719
a40564e
dc1ad3f
deccbf8
3c9e878
8783593
c817641
014f38a
c0c85c9
14ac8c5
f3af281
df1cccd
ead293c
883db6c
dc10b30
f1c76e4
501f6a8
5f4165b
2e71d71
16ec96f
f700460
e970339
4b348b4
efefc08
99d2503
fd94f77
0d79b54
25728c2
d1377ec
c68ff74
b767b00
ab5c06e
7ea0607
fadab66
58a8671
80dc2ed
645de72
d15a016
0069523
7867b3c
8a4c48f
3078527
c1396e5
1055fc0
192b7b3
82ba924
135b6b6
74007ce
bfd02ea
c1a73df
9426f24
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider moving under src/ethernet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to make COMPRESSION factory available LRS wide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider not adding as a library but build into realsense2-net instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is zlib in use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be used instead of lz4. But default - it is not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since compression factory is a singleton please change the design as follows:
a. All methods are not static, enabled is class member
b. Add single static function:
aka mayers singleton.
also, consider not making it singleton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP