Min Distance can't get higher value than the Max Distance #6564

aseelegbaria · 2020-06-10T14:30:42Z

Min Distance can't get higher value than the Max Distance in Threshold Filter and Depth Visualization
Tracked on: DSO-12346, DSO-12163, RS5-8689

ev-mp · 2020-06-15T14:45:36Z

src/rs.cpp

@@ -534,6 +534,21 @@ void rs2_set_option(const rs2_options* options, rs2_option option, float value,
    VALIDATE_NOT_NULL(options);
    VALIDATE_OPTION(options, option);
    options->options->get_option(option).set(value);
+


The logic should be dowstreamed from the API level to the core class, in a way that resembles the Auto-exposure/manual gain relationship.

ev-mp · 2020-06-15T14:56:47Z

src/rs.cpp

+
+    if (option == RS2_OPTION_MIN_DISTANCE) {
+        float max_val = options->options->get_option(RS2_OPTION_MAX_DISTANCE).query();
+        if (max_val < value) {


This flow will result in having min=max=val. It is not clear that this is better than throwing exception

src/option.h

maloel · 2020-09-09T13:51:30Z

src/option.h

+
+   /** \brief class provided a control
+* that changes min distance when changing the max distance value */
+   class max_distance_control : public proxy_option


Can we call these options and not controls?

src/proc/threshold.cpp

src/proc/colorizer.cpp

src/option.h

maloel · 2020-09-10T09:20:36Z

src/option.h

+
+        void enable_recording(std::function<void(const option &)> record_action) override
+        {
+            _recording_function = record_action;


Shouldn't this call _proxy->enable_recording(...)?

I'm OK leaving it as-is, since that's the way it was before, but I'll get @ev-mp input...

aseelegbaria force-pushed the distanceBug branch from 7d31065 to 72ed5be Compare June 15, 2020 07:47

ev-mp requested changes Jun 15, 2020

View reviewed changes

separate classes

4537f40

aseelegbaria force-pushed the distanceBug branch from 72ed5be to 4537f40 Compare September 9, 2020 09:32

add proxy_option class

e74b54f