HW Monitor - Terminal Parser API #6623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-mp
reviewed
Jun 17, 2020
|
|
||
| rs2_raw_data_buffer* rs2_terminal_parse_response(rs2_terminal_parser* terminal_parser, | ||
| const char* command, unsigned int size_of_command, | ||
| const void* response, unsigned int size_of_response, rs2_error** error) BEGIN_API_CALL |
There was a problem hiding this comment.
Add validation for size_of_cmd/response
There was a problem hiding this comment.
done - hope the numbers are ok
ev-mp
changed the title
ev-mp
reviewed
Jun 17, 2020
examples/capture/rs-capture.cpp
Outdated
| @@ -3,12 +3,12 @@ | |||
|
|
|||
| #include <librealsense2/rs.hpp> // Include RealSense Cross Platform API | |||
| #include "example.hpp" // Include short list of convenience functions for rendering | |||
|
|
|||
| #include <fstream> | |||
There was a problem hiding this comment.
This file is not part of the PR
src/rs.cpp
Outdated
| @@ -2988,6 +2988,7 @@ rs2_raw_data_buffer* rs2_terminal_parse_command(rs2_terminal_parser* terminal_pa | |||
| { | |||
| VALIDATE_NOT_NULL(terminal_parser); | |||
| VALIDATE_NOT_NULL(command); | |||
| VALIDATE_LE(size_of_command, 1000); | |||
There was a problem hiding this comment.
Add comment for the hard-coded values - units/explanation
remibettan
force-pushed
the
terminal-parser-only-add-to-api
branch
from
b7a8172
to
70829bc
Compare
ev-mp
reviewed
Jun 17, 2020
src/rs.cpp
Outdated
| { | ||
| VALIDATE_NOT_NULL(terminal_parser); | ||
| VALIDATE_NOT_NULL(command); | ||
| VALIDATE_LE(size_of_command, 1000);//bufer shall be lesss than 1000 kbytes or similar |
src/rs.cpp
Outdated
| VALIDATE_NOT_NULL(terminal_parser); | ||
| VALIDATE_NOT_NULL(command); | ||
| VALIDATE_NOT_NULL(response); | ||
| VALIDATE_LE(size_of_command, 1000); //bufer shall be lesss than 1000 kbytes or similar |
There was a problem hiding this comment.
lesss, .. bytes - appears in several places
remibettan
force-pushed
the
terminal-parser-only-add-to-api
branch
from
bed1cc8
to
1937c3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding terminal parser capability to API.
Auto complete not implemented here.
Triggered by jira ticket: DSO-14959