-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hdr with split as select #7257
Merged
ev-mp
merged 103 commits into
IntelRealSense:development
from
remibettan:hdr-with-split-as-select
Sep 15, 2020
Merged
Hdr with split as select #7257
ev-mp
merged 103 commits into
IntelRealSense:development
from
remibettan:hdr-with-split-as-select
Sep 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-mp
reviewed
Sep 2, 2020
src/ds5/ds5-device.cpp
Outdated
@@ -1035,6 +1126,8 @@ namespace librealsense | |||
processing_blocks get_ds5_depth_recommended_proccesing_blocks() | |||
{ | |||
auto res = get_depth_recommended_proccesing_blocks(); | |||
res.push_back(std::make_shared<merge_filter>()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put // For Review comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBD
remibettan
force-pushed
the
hdr-with-split-as-select
branch
from
September 10, 2020 19:53
52d33ef
to
68ed157
Compare
ev-mp
requested changes
Sep 12, 2020
(cherry picked from commit 3dd6bce) # Conflicts: # include/librealsense2/hpp/rs_processing.hpp # src/hdr-config.cpp
ev-mp
force-pushed
the
hdr-with-split-as-select
branch
from
September 14, 2020 07:58
3dd6bce
to
030de64
Compare
Closed
ev-mp
approved these changes
Sep 15, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: DSO-15603
HDR configuration, processing blocks for merge and split