Fix SW update crash on Viewer #7323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maloel
reviewed
Sep 14, 2020
maloel
reviewed
Sep 14, 2020
| @@ -64,6 +64,7 @@ namespace rs2 | |||
|
|
|||
| versions_db_manager _versions_db; | |||
| update_profile _update_profile; | |||
| bool _keep_trying; | |||
maloel
reviewed
Sep 14, 2020
| } | ||
| else if (query_status == versions_db_manager::DB_LOAD_FAILURE) | ||
| { | ||
| _keep_trying = false; |
There was a problem hiding this comment.
// once we fail to connect, we don't want to try again -- each try is a 5-second maximum wait (e.g., when we have internet but no proxy defined) and we have several calls to try_parse_update(), meaning we could potentially wait even half a minute or more!
maloel
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting a device the SW Update check if a new version is available,
Tracked on [RS5-8694]