-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add l515 frames filter tests #8180
Merged
maloel
merged 5 commits into
IntelRealSense:development
from
Nir-Az:add_l515_frames_filter_ut
Jan 24, 2021
Merged
Add l515 frames filter tests #8180
maloel
merged 5 commits into
IntelRealSense:development
from
Nir-Az:add_l515_frames_filter_ut
Jan 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maloel
reviewed
Jan 20, 2021
maloel
reviewed
Jan 20, 2021
maloel
reviewed
Jan 20, 2021
maloel
reviewed
Jan 20, 2021
maloel
reviewed
Jan 20, 2021
maloel
reviewed
Jan 20, 2021
maloel
reviewed
Jan 20, 2021
maloel
reviewed
Jan 21, 2021
maloel
reviewed
Jan 21, 2021
maloel
reviewed
Jan 21, 2021
maloel
reviewed
Jan 21, 2021
maloel
reviewed
Jan 21, 2021
maloel
reviewed
Jan 21, 2021
maloel
reviewed
Jan 21, 2021
maloel
reviewed
Jan 21, 2021
maloel
reviewed
Jan 24, 2021
maloel
reviewed
Jan 24, 2021
maloel
reviewed
Jan 24, 2021
unit-tests/py/rspy/timer.py
Outdated
|
||
# Check if timer time expired | ||
def has_expired(self): | ||
return self._sw.get_start() + self._delta <= time.perf_counter() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use _self._sw.get_elapsed() >= self._delta
is clearer, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
maloel
reviewed
Jan 24, 2021
maloel
approved these changes
Jan 24, 2021
Nir-Az
force-pushed
the
add_l515_frames_filter_ut
branch
from
January 24, 2021 08:17
e302322
to
d5443f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing that IR frames do not arrive to the user callback if not specifically asked for.
Tracked on [RS5-10249]