LibRS API to enable rolling log files #8207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maloel
reviewed
Jan 21, 2021
| @@ -36,6 +36,13 @@ namespace rs2 | |||
| rs2_reset_logger(&e); | |||
| error::handle(e); | |||
| } | |||
|
|
|||
| inline void enable_rolling_files(std::size_t max_size ) | |||
There was a problem hiding this comment.
Not clear what the unit of measure is for max_size -- is it bytes? KB?
maloel
reviewed
Jan 21, 2021
| @@ -82,6 +82,9 @@ void rs2_log_to_callback( rs2_log_severity min_severity, rs2_log_callback_ptr ca | |||
|
|
|||
| void rs2_reset_logger( rs2_error ** error); | |||
|
|
|||
| void rs2_enable_rolling_files(size_t max_size, rs2_error ** error); | |||
There was a problem hiding this comment.
Please add a /** ... */ description
There was a problem hiding this comment.
rs2_enable_rolling_log_file
maloel
reviewed
Jan 21, 2021
|
|
||
| void librealsense::enable_rolling_files(std::size_t max_size ) | ||
| { | ||
| } |
There was a problem hiding this comment.
why? if so, shouldn't all the other functions also throw?
maloel
reviewed
Jan 21, 2021
| void enable_rolling_files(std::size_t max_size) | ||
| { | ||
| std::string size = std::to_string( max_size/2 ); | ||
| el::Loggers::addFlag(el::LoggingFlag::StrictLogFileSizeCheck); |
There was a problem hiding this comment.
Please explain -- have you tried without?
There was a problem hiding this comment.
Rollout checking happens when Easylogging++ flushes the log file, or, if you have added the flag el::LoggingFlags::StrictLogFileSizeCheck, at each log output.
maloel
reviewed
Jan 21, 2021
| std::remove(old_filename); | ||
| } | ||
|
|
||
| rename(filename, old_filename); |
maloel
reviewed
Jan 21, 2021
| for (int i = 0; i < 100; ++i) | ||
| log_all(); | ||
|
|
||
| std::ifstream log_file(log_filename.c_str(), std::ios::binary); |
There was a problem hiding this comment.
Add reset_logger() before to have it flush everything
|
opened new one: #8212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log files can have a max size. upon reaching max size new file will be created and current file will be truncated.
Tracked on [RS5-9271]