-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SKU B5B #8365
SKU B5B #8365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
e771616
to
695fd28
Compare
common/model-views.h
Outdated
@@ -676,6 +676,10 @@ namespace rs2 | |||
std::vector<std::shared_ptr<processing_block_model>> post_processing; | |||
bool post_processing_enabled = true; | |||
std::vector<std::shared_ptr<processing_block_model>> const_effects; | |||
|
|||
private: | |||
const float SHORT_RANGE_MIN_DISTANCE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Indentation
- Switch from all Capital to regular
common/model-views.cpp
Outdated
detected_objects(device_detected_objects) | ||
detected_objects(device_detected_objects), | ||
SHORT_RANGE_MIN_DISTANCE(0.05f), | ||
SHORT_RANGE_MAX_DISTANCE(1.5f) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if it is possible to increase to 2 up to 3 meter and check how it applies to Colorizer and Threshold filters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
Triggered by: DSO-16440