Fixed deadlock on pipeline.stop() with playback device in non realtime #8625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. added unit test test-non-realtime.py
maloel
reviewed
Mar 21, 2021
| @@ -0,0 +1,31 @@ | |||
| # License: Apache 2.0. See LICENSE file in root directory. | |||
| # Copyright(c) 2020 Intel Corporation. All Rights Reserved. | |||
maloel
reviewed
Mar 21, 2021
| # and non realtime mode is not stuck due to deadlock of | ||
| # pipeline stop thread and syncer blocking enqueue thread (DSO-15157) | ||
| ############################################################################################# | ||
| test.start("Playback with non realtime doesn't stuck at stop") |
There was a problem hiding this comment.
doesn't get stuck
or
isn't stuck
maloel
reviewed
Mar 21, 2021
| ############################################################################################# | ||
| test.start("Playback with non realtime doesn't stuck at stop") | ||
| current_dir = os.path.dirname( os.path.abspath( __file__ )) | ||
| filename = current_dir + os.sep + 'recording.bag' |
There was a problem hiding this comment.
Shouldn't it be called recording_deadlock.bag? I'm confused...
maloel
reviewed
Mar 21, 2021
| @@ -0,0 +1,31 @@ | |||
| # License: Apache 2.0. See LICENSE file in root directory. | |||
There was a problem hiding this comment.
Matan put his record & playback test under func/rec-play/
Talk to him and synchronize please
maloel
reviewed
Mar 21, 2021
maloel
reviewed
Mar 21, 2021
maloel
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[tracked on DSO-15157]