Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SR300 derivative into SDK core #8713

Merged
merged 9 commits into from
Apr 8, 2021

Conversation

nohayassin
Copy link
Contributor

The following tools are functioning in SR300-like device :

  • rs-enumerate-devices
  • Realsense-viewer streaming
  • Realsense-viewer controls

Track on: DSO-16719

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Follow the comments

common/model-views.cpp Outdated Show resolved Hide resolved
src/ivcam/ivcam-private.cpp Outdated Show resolved Hide resolved
src/ivcam/ivcam-private.h Outdated Show resolved Hide resolved
src/ivcam/sr300.cpp Outdated Show resolved Hide resolved
src/context.cpp Outdated Show resolved Hide resolved
src/ivcam/sr300.h Outdated Show resolved Hide resolved
src/ivcam/sr300.h Outdated Show resolved Hide resolved
src/ivcam/sr300.h Outdated Show resolved Hide resolved
src/winusb/handle-winusb.h Outdated Show resolved Hide resolved
tools/benchmark/rs-benchmark.cpp Outdated Show resolved Hide resolved
@ev-mp ev-mp changed the title Adding SR300-like device but without the RGB sensor into the SDK core Adding SR300 derivative into SDK core Apr 4, 2021
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several comments to review/verify

src/ivcam/sr300.cpp Show resolved Hide resolved
src/ivcam/sr300.cpp Outdated Show resolved Hide resolved
src/ivcam/sr300.cpp Outdated Show resolved Hide resolved
src/ivcam/sr300.h Outdated Show resolved Hide resolved
tools/benchmark/rs-benchmark.cpp Outdated Show resolved Hide resolved
tools/depth-quality/depth-quality-model.cpp Outdated Show resolved Hide resolved
src/ivcam/sr300.cpp Outdated Show resolved Hide resolved
src/ivcam/sr300.cpp Outdated Show resolved Hide resolved
src/ivcam/sr300.cpp Outdated Show resolved Hide resolved
src/ivcam/sr300.cpp Outdated Show resolved Hide resolved
common/fw/firmware-version.h Outdated Show resolved Hide resolved
src/ivcam/sr300.cpp Show resolved Hide resolved
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp ev-mp merged commit df2c793 into IntelRealSense:development Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants