Add a CMake flag for disable AVX for OpenVINO #8920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Nir-Az
commented
Apr 28, 2021
Nir-Az
commented
- Add LRS CMake flag BUILD_WITH_CPU_EXTENSIONS default = ON (will affect LRS use of CPU extensions in the future)
- If BUILD_WITH_CPU_EXTENSIONS == OFF disable AVX support for OpenVINO
Nir-Az
changed the title
maloel
reviewed
Apr 28, 2021
maloel
reviewed
Apr 28, 2021
maloel
approved these changes
Apr 28, 2021
ev-mp
reviewed
Apr 28, 2021
| @@ -35,6 +35,7 @@ option(FORCE_LIBUVC "Explicitly turn-on libuvc backend - deprecated, use FORCE_R | |||
| option(FORCE_WINUSB_UVC "Explicitly turn-on winusb_uvc (for win7) backend - deprecated, use FORCE_RSUSB_BACKEND instead" OFF) | |||
| option(ANDROID_USB_HOST_UVC "Build UVC backend for Android - deprecated, use FORCE_RSUSB_BACKEND instead" OFF) | |||
| option(CHECK_FOR_UPDATES "Checks for versions updates" ON) | |||
| option(BUILD_WITH_CPU_EXTENSIONS "Enable compiler optimizations using CPU extensions (such as AVX)" ON) | |||
There was a problem hiding this comment.
The name is misleading as we still use SSE2/SSE3 in default configuration.
We need the additional granularity level and separate AVX,AVX2(512) and may be SSE3 for X86 architecture.
BUILDDISABLE_CPU_EXTENSIONS="AVX2` yo disable itnrinsic of AVX2 and above and then apply it accordingly
There was a problem hiding this comment.
As discussed:
I asked to start with BUILD_ to keep in line with the other options.
The granularity is too much for right now, and I don't see the need or ROI at this point in time. We'll change as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.