Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l500 - metadata display negative brightness and hue corrected #8921

Conversation

remibettan
Copy link
Contributor

Tracked by: DSO-14036

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel
Copy link
Collaborator

maloel commented Apr 29, 2021

Where's the Unit-test?!!?!?!?!
¯\_(ツ)_/¯
🥰

@remibettan
Copy link
Contributor Author

Where's the Unit-test?!!?!?!?!
¯\_(ツ)_/¯
🥰

I don't think it is needed here - let's talk about it

@remibettan remibettan force-pushed the l500-color-metadata-display-negative-values branch 2 times, most recently from ef99276 to 4ba8fc9 Compare May 9, 2021 05:21
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I put minor remarks

unit-tests/func/options/test-color-options.py Outdated Show resolved Hide resolved
unit-tests/func/options/test-color-options.py Outdated Show resolved Hide resolved
unit-tests/func/options/test-color-options.py Outdated Show resolved Hide resolved
unit-tests/func/options/test-color-options.py Outdated Show resolved Hide resolved
unit-tests/func/options/test-color-options.py Outdated Show resolved Hide resolved
unit-tests/func/options/test-color-options.py Outdated Show resolved Hide resolved
@remibettan remibettan requested a review from ev-mp May 9, 2021 19:24
@remibettan remibettan force-pushed the l500-color-metadata-display-negative-values branch from 82a8d84 to 2130364 Compare May 10, 2021 13:43
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ev-mp ev-mp merged commit 6a595d3 into IntelRealSense:development May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants