Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D400 Calibration extensions in C# #9256

Merged
merged 11 commits into from
Jul 4, 2021
Merged

Conversation

ev-mp
Copy link
Collaborator

@ev-mp ev-mp commented Jun 20, 2021

Follow up on @DenisGeek's work in #8773

@DenisGeek

This comment has been minimized.

Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - few comments added

@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jun 21, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jun 21, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jun 21, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jun 21, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jun 21, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jun 21, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jun 21, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jun 21, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jun 21, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jun 21, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jun 21, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jun 21, 2021
Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DenisGeek and others added 9 commits June 30, 2021 19:34
using each Depth profile, which available for device performs next 16 calibration combinations (in case of windows otherwise 8):

CalibrationSpeed
            VeryFast,   // (0.66 seconds), for small depth degradation
            Fast,       // (1.33 seconds), medium depth degradation.This is the recommended setting.
            Medium,     // (2.84 seconds), medium depth degradation.
            Slow,       // (Default) (2.84 seconds), for significant depth degradation.
CalibrationScanParameter
            Intrinsic,  // (default) Intrinsic calibration correction. The intrinsic distortion comes about through microscopic shifts in the lens positions
            Extrinsic,  // Extrinsic calibration correction. Extrinsic distortions are related to microscopic bending and twisting of the stiffener on which the two stereo sensors are mounted
CalibrationDataSampling
            WindowsAndLinux,// default is 0 which uses a polling approach that works on Windows and Linux
            Windows,        // Windows it is possible to select 1 which is interrupt data sampling which is slightly faster

Test calibration report will be written to the file ReportTestCalibrationModes.csv in application working directory
Change-Id: I6003907fd8d48fe6b397b521ec3e5dc8da3b5d4d
Change-Id: Ie861e9a14b42ddf8696c9567d5b8439a05fb2ca5
Remove unused var.

Change-Id: I528b24e0d63c0304cedcad645baeefc0d7580b41
Change-Id: I2b00c9420cd511e77cd646a3e7628da83010ba4e
Change-Id: I9c89a91797b96b41006e0fed8263fc485920e916
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jul 4, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jul 4, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jul 4, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jul 4, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jul 4, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jul 4, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jul 4, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jul 4, 2021
@ev-mp ev-mp merged commit 3fe95d4 into IntelRealSense:development Jul 4, 2021
@IntelRealSense IntelRealSense deleted a comment from DenisGeek Jul 4, 2021
@ev-mp ev-mp deleted the csh_tare branch July 8, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants