close API fixed - openSensor with multiple profiles API added #9320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remibettan
commented
Jun 30, 2021
| if (depth_sensor != null) { | ||
| List<StreamProfile> sps = depth_sensor.getStreamProfiles(); | ||
| StreamProfile sp = sps.get(0); | ||
| StreamProfile depth_profile = sps.get(0); | ||
| StreamProfile ir_profile = sps.get(0); | ||
|
|
||
| for (StreamProfile sp2 : sps) { |
There was a problem hiding this comment.
sp2 - change to stream_profile
sps - change to stream_profiles
| @@ -203,14 +210,40 @@ private void configAndStart() throws Exception { | |||
| if (w == 640 && fps == 30 && (sf.compareTo(StreamFormat.Z16) == 0)) { | |||
There was a problem hiding this comment.
check also height (for both profiles)
| Log.d(TAG, "ir stream: " + index + ":" + st.name() + ":" + sf.name() + ":" + w + "x" + h + "@" + fps + "HZ"); | ||
|
|
||
| ir_profile = sp2; | ||
| ir_profile_found = true; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
add exception if profiles were not found - or if only one was found, play only this one, and add a toast message on the missing profile
ev-mp
reviewed
Jul 1, 2021
src/android/jni/sensor.cpp
Outdated
| JNIEXPORT void JNICALL | ||
| Java_com_intel_realsense_librealsense_Sensor_nOpenMultiple(JNIEnv *env, jclass type, jlong device_handle, | ||
| jlongArray profiles_handle, int num_of_profiles) { | ||
| // retreiving profiles from array |
remibettan
force-pushed
the
android-sensor-api-multiple-profiles
branch
from
ffd33ae
to
07230d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: LRS-132
Using Sensor example, we get (using the new API for getting both depth and infrared profiles from depth sensor):